Re: [PATCH] git-bisect: allow running in a working tree subdirectory

Stefan Beller [off-list ref] writes:

+ Duy, main author of the worktree feature.

On Thu, Jan 26, 2017 at 10:30 AM,  [off-list ref] wrote:

quoted

From: Marc-André Lureau <redacted>

It looks like it can do it.

Signed-off-by: Marc-André Lureau <redacted>
---

I do not think the OP meant by "a working tree subdirectory" using
the command in a secondary worktree.  SUBDIRECTORY_OK is about "can
the command be started in a subdirectory (as opposed to requiring to
be run only at the toplevel)?"

I am slightly negative on this change, though.  The subdirectory you
are sitting in when you start your bisection may disappear and reappear
as you dig the history, and I do not think the code makes anything
special to prevent the disappearing current directory from getting
in the way of bisection process.

quoted

 git-bisect.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-bisect.sh b/git-bisect.sh
index ae3cb013e..b0bd604d4 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh

@@ -1,5 +1,6 @@
 #!/bin/sh

+SUBDIRECTORY_OK=Yes
 USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
 LONG_USAGE='git bisect help
        print this long help message.
--

2.11.0.295.gd7dffce1c.dirty