Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

Hi Junio,

On Wed, 25 Jan 2017, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

Now, with the patch in question (without the follow-up, which I would
like to ask you to ignore, just like you did so far), Git would not
figure out that your script calls PuTTY eventually. The work-around?
Easy:

	DUMMY=/plink.exe /path/to/junio-is-a-superstar.sh

Think about how you would explain that to an end-user in our document?
You'll need to explain how exactly the auto-detection works, so that the
user can "exploit" the loophole to do that.  And what maintenance burden
does it add when auto-detection is updated?

Fine, you do not like it. Saying so (instead of asking me questions) would
have been helpful.

I think I know you well enough that you know well enough that it is too
ugly to live, and I suspect that the above is a tongue-in-cheek "arguing
for the sake of argument" and would not need a serious response, but
just in case...

It was not tongue-in-cheek, I was being serious.

Yes.  Here is what comes on an obvious clean-up patch (which will be
sent as a follow-up to this message).

I'd much rather prefer
https://github.com/git-for-windows/git/pull/1030 than your patch.

Ciao,
Johannes