Thread (1 message) 1 message, 1 author, 2017-01-25

Re: [PATCH 4/5] revision.c: refactor ref selection handler after --exclude

From: Junio C Hamano <hidden>
Date: 2017-01-25 23:26:04

Jacob Keller [off-list ref] writes:
On Wed, Jan 25, 2017 at 1:27 PM, Jeff King [off-list ref] wrote:
quoted
On Wed, Jan 25, 2017 at 03:57:18PM -0500, Jeff King wrote:
quoted
IOW, the ref-selector options build up until a group option is given,
which acts on the built-up options (over that group) and then resets the
built-up options. Doing "--unrelated" as above is orthogonal (though I
think in practice nobody would do that, because it's hard to read).
So here's what I would have expected your series to look more like (with
probably one patch adding clear_ref_selection_options, and the other
adding the decorate stuff):
I agree that this is how I would have expected it to work as well.
That makes three of us ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help