Re: [PATCH 7/7] completion: recognize more long-options
From: Cornelius Weig <hidden>
Date: 2017-01-24 08:21:10
On 01/24/2017 08:15 AM, Johannes Sixt wrote:
If at all possible, please use your real email address as the From address. It is pointless to hide behind a fake address because as Git contributor you will have to reveal your identity anyway.
These are both real addresses, but for send-mail I would not want to use my work account. I hope this is not a problem.
Please study item (5) "Sign your work" in Documentation/SubmittingPatches and sign off your work.
I followed the recommendations to submitting work, and in the first round signing is discouraged.
AFAIR, it was a deliberate decision that potentially destructive command line options are not included in command completions. In the list given, I find these:quoted
- reset: --merge --mixed --hard --soft --patch --keep
My bad, I only added --keep, which should be fine. As to these options
quoted
- apply: --unsafe-paths - rm: --force
let's wait for further comments, but I won't cling to it.
Additionally, these options are only for internal purposes, but I may be wrong:quoted
- archive: --remote= --exec=
These may in fact be too exotic and just clutter the command line. Best they are removed. -- Cornelius