Thread (29 messages) 29 messages, 3 authors, 2017-02-08

Re: [PATCH 0/12] reducing resource usage of for_each_alternate_ref

From: Jeff King <hidden>
Date: 2017-01-24 02:12:26

On Mon, Jan 23, 2017 at 05:33:41PM -0800, Brandon Williams wrote:
On 01/23, Jeff King wrote:
quoted
A brief overview of the patches:

  [01/12]: for_each_alternate_ref: handle failure from real_pathdup()
  [02/12]: for_each_alternate_ref: stop trimming trailing slashes
  [03/12]: for_each_alternate_ref: use strbuf for path allocation

    Bugfixes and cleanups (the first one is actually a recent-ish
    regression).
Which is most likely my fault, Sorry! :)

I think the old behavior was to die and not return NULL.
Yes, it is. :)

But I think it's probably pretty hard to trigger in practice. And on the
plus side, I think the new behavior after my patch is much more sensible
than even the original.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help