Thread (1 message) 1 message, 1 author, 2017-01-20

Re: [PATCH] show-ref: Allow --head to work with --verify

From: Junio C Hamano <hidden>
Date: 2017-01-20 22:31:47

Junio C Hamano [off-list ref] writes:
quoted
My use case was the following series of steps:
... long and readable if a bit too verbose description ...
Your log message for the patch needs to be updated by summarizing
the above better.
That raises the number of things to improve in the patch to 3 (so
far):

 * the log message clarification.

 * the code change I mentioned already to hook into the existing
   "only read the fully specified ref" part, sharing the actual
   action (i.e. read_ref() to read it, honor quiet and show it by
   calling show_one()), instead of adding another clause that does
   it differently (i.e. you didn't do read_ref/quiet?/show_one)

 * add a test to make sure that the command also works sensibly when
   --quiet is used.

With all of the above, I think the change makes sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help