Thread (3 messages) flat view 3 messages, 3 authors, 2017-01-20

Re: [RFC 2/2] grep: use '/' delimiter for paths

From: Jeff King <hidden>
Date: 2017-01-20 14:26:43

On Fri, Jan 20, 2017 at 02:12:12PM +0000, Stefan Hajnoczi wrote:
I find <rev>:<path> vs <rev> -- <path> confusing:

            | <rev>:<path>         | <rev> -- <path>
  ----------+----------------------+---------------------
  git grep  | OK                   | OK
  ----------+----------------------+---------------------
  git show  | OK                   | <path> ignored
  ----------+----------------------+---------------------
  git log   | no output            | OK
  ----------+----------------------+---------------------

Neither syntax always does what I expect.  If git show <rev> -- <path>
honored <path> then I could use that syntax consistently.

Sorry for going on a tangent.  Does it seem reasonable to handle <path>
in git-show(1) as a UI convenience?
It's not ignored; just as with git-log, it's a pathspec to limit the
diff. E.g.:

  $ git show --name-status v2.9.3
  ...
  M       Documentation/RelNotes/2.9.3.txt
  M       Documentation/git.txt
  M       GIT-VERSION-GEN

  $ git show --name-status v2.9.3 -- Documentation
  M       Documentation/RelNotes/2.9.3.txt
  M       Documentation/git.txt

That's typically less useful than it is with log (where limiting the
diff also kicks in history simplification and omits some commits
entirely). But it does do something.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help