Re: [PATCH] mingw: follow-up to "replace isatty() hack"

Johannes Sixt [off-list ref] writes:

quoted

quoted

-	dup2(new_fd, fd);
 	if (console == handle)
 		console = duplicate;
-	handle = INVALID_HANDLE_VALUE;
+	dup2(new_fd, fd);

 	/* Close the temp fd.  This explicitly closes "new_handle"
 	 * (because it has been associated with it).

Looks good and obviously correct (FLW). I can offer a

Reviewed-by: Johannes Sixt <redacted>

but it will take a day or two until I can test the patch.

I think a Reviewed-by is good enough, as the original

[ref]

already has "Tested-by" to indicate that as a whole this have been
tested.  The "follow-up" we are commenting on was made out of that
original to incrementally update the older version that was queued
and merged to 'master' 3 weeks ago.

Thanks.