Re: [BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash

Hi Max,

On Tue, 17 Jan 2017, Max Kirillov wrote:

On Tue, Jan 17, 2017 at 11:52:29AM +0100, Johannes Schindelin wrote:

quoted

And having said *that*, I have to admit that I was unable to reproduce

I have found exact way to reproduce it and actually the reason. Turns
out to be obvious mistake in code. PR is in github:
https://github.com/git-for-windows/git/pull/1032

As I pointed out in my review, I think that GIT_DIR is actually only set
for `gitk` in the non-submodule case. So I guess if I run Git GUI, spawn
gitk, and then Git Bash, it will have GIT_DIR set.

*clicketyclick*

Bingo. That reproduces the problem here.

Thanks,
Johannes