Thread (21 messages) flat view 21 messages, 2 authors, 2017-01-17

Re: [PATCH v5 3/7] tag: add format specifier to gpg_verify_tag

From: Jeff King <hidden>
Date: 2017-01-17 15:25:05

On Sun, Jan 15, 2017 at 01:47:01PM -0500, santiago@nyu.edu wrote:
From: Lukas Puehringer <redacted>

Calling functions for gpg_verify_tag() may desire to print relevant
information about the header for further verification. Add an optional
format argument to print any desired information after GPG verification.
Hrm. Maybe I am missing something, but what does:

  verify_and_format_tag(sha1, name, fmt, flags);

get you over:

  gpg_verify_tag(sha1, name, flags);
  pretty_print_ref(name, sha1, fmt);

? The latter seems much more flexible, and I do not see how the
verification step impacts the printing at all (or vice versa).

I could understand it more if there were patches later in the series
that somehow used the format and verification results together. But I
didn't see that.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help