Thread (4 messages) 4 messages, 4 authors, 2017-01-16

Re: [PATCH v3 01/38] sequencer: avoid unnecessary curly braces

flat view

From: Johannes Schindelin <hidden>
Date: 2017-01-14 18:04:06

Hi Junio,

On Thu, 12 Jan 2017, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
 
-	if (!commit->parents) {
+	if (!commit->parents)
 		parent = NULL;
-	}
 	else if (commit->parents->next) {
 		/* Reverting or cherry-picking a merge commit */
 		int cnt;
The result becomes

	if (...)
		single statement;
	else if (...) {
		multiple;
                statements;
        }

which is not quite an improvement.  
Yet, this used to be the coding style of Git, and your statement comes
quite as a surprise to me.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help