Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile
From: Junio C Hamano <hidden>
Date: 2017-01-11 20:55:34
Jeff King [off-list ref] writes:
On Tue, Jan 10, 2017 at 02:15:11PM -0800, Junio C Hamano wrote:quoted
Richard Hansen [off-list ref] writes: ...quoted
I think so. (For bare repositories anyway; non-bare should be relative to GIT_WORK_TREE.) Perhaps git_config_pathname() itself should convert relative paths to absolute so that every pathname setting automatically works without changing any calling code.Yes, that was what I was alluding to. We might have to wait until major version boundary to do so, but I think that it is the sensible way forward in the longer term to convert relative to absolute in git_config_pathname().Yeah, I'd agree. I'm undecided on whether it would need to happen at a major version bump. ... So I dunno. I do hate to break even corner cases, but I'm having trouble imagining the scenario where somebody is actually using the current behavior in a useful way.
Thanks for a detailed analysis (I probably should have spelt them out when I said "we might have to" to save you the trouble).