Thread (10 messages) flat view 10 messages, 3 authors, 2017-01-09

Re: [PATCHv2] unpack-trees: move checkout state into check_updates

From: Stefan Beller <hidden>
Date: 2017-01-06 21:04:10

Possibly related (same subject, not in this thread)

On Sat, Dec 31, 2016 at 5:26 PM, Junio C Hamano [off-list ref] wrote:
quoted
Signed-off-by: Stefan Beller <redacted>
---
I'd add René's Reviewed-by: here.
done
I think moving heavier and initialized variables earlier and more
lightweight and ephemeral ones like "i" later does make it easier to
follow.  "errs" has the significance and the lifetime similar to
cnt/total, and logically should be higher, though.  It is not a big
enough deal to reroll (but as your futzing of the variable definition
order was not a big enough deal to do in this patch, either, so...).
I will send out a series, that is based on this patch shortly;
as I fuzzed again with the small variables, that series doesn't
apply on this version but the version to be sent out shortly.
Queued.  Thanks.
please replace with the following series.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help