Thread (4 messages) 4 messages, 3 authors, 2017-01-04

Re: [PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistently

From: Jeff King <hidden>
Date: 2017-01-04 01:20:04

On Tue, Jan 03, 2017 at 10:30:47AM -0800, Stefan Beller wrote:
In C code we have the luxury of having constants for all the important
things that are hard coded. This is the only place in C, that hard codes
the git directory environment variable, so fix it.

Signed-off-by: Stefan Beller <redacted>
This looks like a good change to me.

Minor nit: the comma after "C" in your commit message is extraneous. ;)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help