Thread (2 messages) read the whole thread 2 messages, 2 authors, 2017-01-01

Re: [PATCH v3 11/23] log_ref_setup(): separate code for create vs non-create

From: Junio C Hamano <hidden>
Date: 2017-01-01 03:28:55

Michael Haggerty [off-list ref] writes:
+			if (errno == ENOENT || errno == EISDIR) {
+				/*
+				 * The logfile doesn't already exist,
+				 * but that is not an error; it only
+				 * means that we won't write log
+				 * entries to it.
+				 */
+			} else {
It may be valid C, but an

	{
		/*
		 * an empty block without any statement,
		 * not even a null statement.
		 */
	}

always makes me a bit nervous.  Have a line with a semicolon without
anything else (other than the indent) at the end and it will read
nicer, at least to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help