Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR
flat view
From: Stefan Beller <hidden>
Date: 2016-12-30 00:39:55
quoted hunk ↗ jump to hunk
+ mkdir lsremote-root && + ( + GIT_CEILING_DIRECTORIES=$(pwd) && + export GIT_CEILING_DIRECTORIES && + cd lsremote-root && + git ls-remote "$HTTPD_URL/smart/repo.git" >../actual + ) &&
We could avoid the subshell via
GIT_CEILING_DIRECTORIES=$(pwd) \
git -C lsremote-root lsremote ... >actual
Not sure if it is worth to trade off a block of code (and an extra shell
at run time) for an overly long line.
The rest looks good to me.
Thanks,
Stefan