Re: [PATCH] am: add am.signoff add config variable
From: Junio C Hamano <hidden>
Date: 2016-12-29 21:42:21
Eric Wong [off-list ref] writes:
Eduardo Habkost [off-list ref] wrote:quoted
git-am has options to enable --message-id and --3way by default, but no option to enable --signoff by default. Add a "am.signoff" config option.I'm not sure this is a good idea. IANAL, but a sign-off has some sort of legal meaning for this project (DCO) and that would be better decided on a patch-by-patch basis rather than a blanket statement.
IANAL either, but we have been striving to keep output of $ git grep '\.signoff' Documentation empty to keep Sign-off meaningful. Adding more publicized ways to add SoB without thinking will make it harder to argue against one who tells the court "that log message ends with a SoB by person X but it is very plausible that it was done by inertia without person X really intending to certify what DCO says, and the SoB is meaningless".
I don't add my SoB to patches (either my own or received) until I'm comfortable with it; and I'd rather err on the side of forgetting and being prodded to resubmit rather than putting an SoB on the wrong patch.