Thread (5 messages) 5 messages, 3 authors, 2016-12-23

Re: [PATCH] diff: prefer indent heuristic over compaction heuristic

From: Jeff King <hidden>
Date: 2016-12-23 16:19:26

Possibly related (same subject, not in this thread)

On Fri, Dec 23, 2016 at 12:12:13AM -0800, Jacob Keller wrote:
I actually would prefer that we just say "this is the default now" and
provide some knob "no-indent-heuristic" or "no-compaction-heuristic"
and go with that, I think, since I am pretty sure we're all in
agreement that the heuristic is an improvement in almost every case,
certainly all the ones we've found. It's at least not worse in any
case I've seen, and is usually better.

Thoughts? I don't have a super strong opinion about which name we went
with for the knob.
Yes, I think we should also make --indent-heuristic the default. That's
technically orthogonal to the name, but I agree the name becomes a lot
less important when it is just on by default.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help