Thread (20 messages) 20 messages, 6 authors, 2016-12-22

Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

From: Jeff King <hidden>
Date: 2016-12-22 22:19:19

On Thu, Dec 22, 2016 at 08:06:02PM +0100, Johannes Sixt wrote:
Am 22.12.2016 um 07:13 schrieb Johannes Sixt:
quoted
Am 21.12.2016 um 23:42 schrieb Jeff King:
quoted
Hmph. I explicitly avoided a colon in the filename so that it would run
on MINGW. Is a double-quote also not allowed?
It is not allowed; that was my conclusion. But now that you ask, I'll
double-check.
Ok, the point is that I get this error:

mv: cannot move `one.git' to `"one.git'

I don't feel inclined to find out which of 'mv' or the Windows API or the
NTFS driver prevents the double-quotes and come up with a work-around just
to get the test to run in some form. Let's leave it at the !MINGW
prerequisite.
Thank you for double-checking (and sorry if my initial question was
confusing; I somehow missed the mention of dq in your subject line, and
just read the message body).

Your patch seems like the best solution.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help