Thread (1 message) 1 message, 1 author, 2016-12-22

Re: [PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

From: Junio C Hamano <hidden>
Date: 2016-12-22 21:23:41

Luke Diamand [off-list ref] writes:
The change puts the logic into stripRepoPath() instead, which is
indeed called from both of those functions (good), but also from
splitFilesIntoBranches(), but only if self.useClientSpec is set. That
function only gets used if we're doing the automatic branch detection
logic, so it's possible that this code might now be broken and we
wouldn't know.

Lars, what do you think? Other than the above, the change looks good,
so it may all be fine.

(As an aside, this is the heart of the code that's going to need some
careful rework if/when we ever move to Python3).
Thanks.  

I'll merge this as-is to 'next', expecting that further refinement
can be done incrementally.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help