Thread (4 messages) flat view 4 messages, 2 authors, 2016-12-13

Re: [PATCHv2] git-p4: support git worktrees

From: Duy Nguyen <hidden>
Date: 2016-12-13 11:18:14

On Sun, Dec 11, 2016 at 2:19 PM, Luke Diamand [off-list ref] wrote:
On 10 December 2016 at 21:57, Luke Diamand [off-list ref] wrote:
quoted
git-p4 would attempt to find the git directory using
its own specific code, which did not know about git
worktrees. This caused git operations to fail needlessly.

Rework it to use "git rev-parse --git-dir" instead, which
knows about worktrees.
Actually this doesn't work as well as the original version. "git
rev-parse --git-dir" won't go and find the ".git" subdirectory. The
previous version would go looking for it, so this would introduce a
regression.
Maybe git rev-parse --git-path HEAD, then strip out the /HEAD part?
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help