Thread (6 messages) flat view 6 messages, 2 authors, 2016-12-12

Re: [PATCH v3] gitk: Fix missing commits when using -S or -G

From: Paul Mackerras <hidden>
Date: 2016-12-12 01:58:41

On Sat, Jun 04, 2016 at 10:47:16AM +0200, Stefan Dotterweich wrote:
When -S or -G is used as a filter option, the resulting commit list
rarely contains all matching commits. Only a certain number of commits
are displayed and the rest are missing.

"git log --boundary -S" does not return as many boundary commits as you
might expect. gitk makes up for this in closevargs() by adding missing
parent (boundary) commits. However, it does not change $numcommits,
which limits how many commits are shown. In the end, some commits at the
end of the commit list are simply not shown.

Change $numcommits whenever a missing parent is added.

Signed-off-by: Stefan Dotterweich <redacted>
Thanks, applied, with slight tweaks to the commit message.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help