Thread (1 message) 1 message, 1 author, 2016-11-23

Re: [PATCH] merge-recursive.c: use QSORT macro

From: Junio C Hamano <hidden>
Date: 2016-11-23 17:21:33

Jeff King [off-list ref] writes:
Another possibility is:

  df_sorted_entries.cmp = string_list_df_name_compare;
  string_list_sort(&df_sorted_entries);

It's not any shorter, but maybe it's conceptually simpler.
My first reaction to Duy's patch was: it is moronic for the
string-list API not to offer "I've done _append() to add many items
while avoiding the overhead of doing insertion sort all the time;
now I finished adding and I want the result sorted".

And then I looked at string-list.h and there it was ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help