Re: [PATCH 1/3] rebase -i: identify problems with core.commentchar

On Mon, Nov 21, 2016 at 11:12:39AM -0800, Junio C Hamano wrote:

quoted

Yeah, I noticed that while reading the patch. My b9605bc4f2 did regress
this case, but called out the fact that "cd subdir && git stripspace"
would never have worked. So one step back, 2 steps forward, and Dscho's
patch is the right step forward.

Yes, absolutely.

I sent out a set of proposed amends, and the one for this step 1/3
runs the command inside a subdirectory to force it not to find the
.git/config file relative to its pwd, which can reveal the existing
breakage without help by b9605bc4f2 ;-) hence can be forked for
older maintenance tracks.

Makes sense, and your amended patch looks good.

-Peff