[PATCH] git-gui: Sort entries in optimized tclIndex
From: Anders Kaseorg <hidden>
Date: 2016-11-16 21:51:25
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Anders Kaseorg <hidden>
Date: 2016-11-16 21:51:25
Subsystem:
the rest · Maintainer:
Linus Torvalds
auto_mkindex expands wildcards in directory order, which depends on the underlying filesystem. To improve build reproducibility, sort the list of *.tcl files in the Makefile. The unoptimized loading case (7 lines below) was previously fixed in v2.11.0-rc0~31^2^2~14 “git-gui: sort entries in tclIndex”. Signed-off-by: Anders Kaseorg <redacted> --- git-gui/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index fe30be38d..f94b3e13d 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile@@ -252,7 +252,7 @@ $(ALL_MSGFILES): %.msg : %.po lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS $(QUIET_INDEX)if echo \ $(foreach p,$(PRELOAD_FILES),source $p\;) \ - auto_mkindex lib '*.tcl' \ + auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \ | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \ else \ echo >&2 " * $(TCL_PATH) failed; using unoptimized loading"; \
--
2.11.0.rc0