Re: [PATCH] attr: mark a file-local symbol as static
From: Stefan Beller <hidden>
Date: 2016-11-14 20:00:30
On Sun, Nov 13, 2016 at 8:42 AM, Ramsay Jones [off-list ref] wrote:
Signed-off-by: Ramsay Jones <redacted> --- Hi Stefan, If you need to re-roll your 'sb/attr' branch, could you please squash this into the relevant patch.
will do. I have it applied locally
Alternatively, since there is only a single call site for git_attr() (on line #1005), you could perhaps remove git_attr() and inline that call. (However, that does make that line exceed 80 columns).
I'll look into that. Thanks, Stefan
quoted hunk ↗ jump to hunk
Thanks! ATB, Ramsay Jones attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/attr.c b/attr.c index 667ba85..84c4b08 100644 --- a/attr.c +++ b/attr.c@@ -169,7 +169,7 @@ static struct git_attr *git_attr_internal(const char *name, int len) return a; } -struct git_attr *git_attr(const char *name) +static struct git_attr *git_attr(const char *name) { return git_attr_internal(name, strlen(name)); } --2.10.0