Thread (26 messages) flat view 26 messages, 7 authors, 2016-11-08

Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

From: Jeff King <hidden>
Date: 2016-11-03 20:44:46

On Thu, Nov 03, 2016 at 09:40:01PM +0100, Johannes Sixt wrote:
quoted
 TEST_ROOT="$(pwd)"
+PATH=$TEST_ROOT:$PATH
This causes problems on Windows. We need the following squashed in.

---- 8< ----
[PATCH] squash! t0021: put $TEST_ROOT in $PATH

We have to use $PWD instead of $(pwd) because on Windows the
latter would add a C: style path to bash's Unix-style $PATH
variable, which becomes confused by the colon after the
drive letter. ($PWD is a Unix-style path.)
Thanks. I have to admit I remain confused about which one to use at any
given invocation (I would have thought that switching to $PWD causes
problems elsewhere in the script, but I guess file redirection is
capable of handling either type).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help