Re: [PATCH v2 1/2] read-cache: factor out get_sha1_from_index() helper
From: Junio C Hamano <hidden>
Date: 2016-10-27 19:57:48
tboegi@web.de writes:
quoted hunk
From: Torsten Bögershausen <redacted> Factor out the retrieval of the sha1 for a given path in read_blob_data_from_index() into the function get_sha1_from_index(). This will be used in the next commit, when convert.c can do the analyze for "text=auto" without slurping the whole blob into memory at once. Add a wrapper definition get_sha1_from_cache(). Signed-off-by: Torsten Bögershausen <redacted> --- cache.h | 3 +++ read-cache.c | 29 ++++++++++++++++++----------- 2 files changed, 21 insertions(+), 11 deletions(-)diff --git a/cache.h b/cache.h index 1604e29..04de209 100644 --- a/cache.h +++ b/cache.h@@ -380,6 +380,7 @@ extern void free_name_hash(struct index_state *istate); #define unmerge_cache_entry_at(at) unmerge_index_entry_at(&the_index, at) #define unmerge_cache(pathspec) unmerge_index(&the_index, pathspec) #define read_blob_data_from_cache(path, sz) read_blob_data_from_index(&the_index, (path), (sz)) +#define get_sha1_from_cache(path) get_sha1_from_index (&the_index, (path))
Should have caught this earlier, but there is an extra SP after "from_index" which I'll remove (the topic is not in 'next' yet, lucky us). I re-read this to ensure that it does not break read_blob_data_from_index() the new function borrows the logic from. Thanks.