Re: [PATCH] git-compat-util: move content inside ifdef/endif guards
From: Junio C Hamano <hidden>
Date: 2016-10-27 17:37:22
Jeff King [off-list ref] writes:
Commit 3f2e2297b9 (add an extra level of indirection to main(), 2016-07-01) added a declaration to git-compat-util.h, but it was accidentally placed after the final #endif that guards against multiple inclusions. This doesn't have any actual impact on the code, since it's not incorrect to repeat a function declaration in C. But it's a bad habit, and makes it more likely for somebody else to make the same mistake. It also defeats gcc's optimization to avoid opening header files whose contents are completely guarded. Signed-off-by: Jeff King <redacted> --- I just happened to notice this today while doing something unrelated in the file.
Thanks.
quoted hunk
git-compat-util.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/git-compat-util.h b/git-compat-util.h index 91e366d1dd..771ea29f31 100644 --- a/git-compat-util.h +++ b/git-compat-util.h@@ -1042,6 +1042,6 @@ struct tm *git_gmtime_r(const time_t *, struct tm *); #define getc_unlocked(fh) getc(fh) #endif -#endif - extern int cmd_main(int, const char **); + +#endif