Re: [PATCH 27/36] attr: convert to new threadsafe API

On Tue, Oct 25, 2016 at 2:18 AM, Stefan Beller [off-list ref] wrote:

On Mon, Oct 24, 2016 at 11:55 AM, Junio C Hamano [off-list ref] wrote:

quoted

Make that a double-asterisk.  The same problem appears in an updated
example in technical/api-gitattributes.txt doc, but the example in
the commit log message (below) is correct.

The implementation is actually using a double pointer, see below,
I forgot commit message and documentation

quoted

quoted

    GIT_ATTR_RESULT_INIT_FOR(myresult, 1);

Are you sure about this?  We've called attr_check_initl() already so
if this is declaring myresult, it would be decl-after-stmt.

I forgot to update the commit message and Documentation.
GIT_ATTR_RESULT_INIT_FOR is gone

I was asking whether this function/macro was not thread-safe and found
out it didn't exist as well, and it's bed time so I'm stopping. Will
continue my skimming on the next re-roll :)
-- 
Duy