[PATCH 04/36] attr.c: explain the lack of attr-name syntax check in parse_attr()
From: Stefan Beller <hidden>
Date: 2016-10-22 23:32:51
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Junio C Hamano <redacted> Signed-off-by: Junio C Hamano <redacted> Signed-off-by: Stefan Beller <redacted> --- attr.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/attr.c b/attr.c
index 4ae7801..05db667 100644
--- a/attr.c
+++ b/attr.c@@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp, return NULL; } } else { + /* + * As this function is always called twice, once with + * e == NULL in the first pass and then e != NULL in + * the second pass, no need for invalid_attr_name() + * check here. + */ if (*cp == '-' || *cp == '!') { e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET; cp++;
--
2.10.1.508.g6572022