Re: [PATCH 3/3] transport: allow summary-width to be computed dynamically

Jeff King [off-list ref] writes:

On Fri, Oct 21, 2016 at 09:39:45PM -0700, Junio C Hamano wrote:

quoted

And this is the final one.

-- >8 --
From: Junio C Hamano <redacted>
Date: Fri, 21 Oct 2016 21:33:06 -0700
Subject: [PATCH] transport: compute summary-width dynamically

Now all that is left to do is to actually iterate over the refs
and measure the display width needed to show their abbreviation.

I think we crossed emails. :) This is obviously correct, if we don't
mind paying the find_unique_abbrev cost twice for each sha1.

Indeed we did.  I do not think the cost matters that much in the
codepath to produce the final summary output.

This is a minor style nit, but I think it's better to avoid mixing
unrelated bits between the initialization, condition, and iteration bits
of a for loop.

Yeah, you're right.