Re: [PATCH v4 1/7] gpg-interface, tag: add GPG_VERIFY_QUIET flag

On Fri, Oct 07, 2016 at 05:07:15PM -0400, santiago@nyu.edu wrote:

From: Lukas Puehringer <redacted>

Functions that print git object information may require that the
gpg-interface functions be silent. Add GPG_VERIFY_QUIET flag and prevent
print_signature_buffer from being called if flag is set.

The layering here is a little funny. The gpg-interface code allocates a
new flag, but none of its functions do anything with it.  Instead, it's
acted on only by the run_gpg_verify() command local to tag.c.

I guess this "flags" variable comes to us from other callsites via
gpg_verify_tag. That's still in tag.c, but it's arguably part of the gpg
interface.

So I think it's OK.

-Peff