Thread (2 messages) flat view 2 messages, 2 authors, 2016-10-18

Re: [PATCH] submodule--helper: normalize funny urls

From: Stefan Beller <hidden>
Date: 2016-10-18 17:17:50

On Tue, Oct 18, 2016 at 10:15 AM, Junio C Hamano [off-list ref] wrote:
I also somehow find the "check-url-stripping" variable ugly.

        while (URL still has something that could be stripped) {
for(;;) {

here ? (this code would not need a variable, and
for wins over while:
$ git grep "while (1)" |wc -l
107
$ git grep "for (;;)" |wc -l
128
)
                if (ends with "/.") {
                        strip "/.";
                        continue;
                }
                if (ends with "/") {
                        strip "/";
                        continue;
                }
                break;
        }

perhaps?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help