Thread (1 message) 1 message, 1 author, 2016-10-10

Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

From: Junio C Hamano <hidden>
Date: 2016-10-10 16:46:48

Jeff King [off-list ref] writes:
On Sun, Oct 09, 2016 at 07:53:23PM -0700, Jeremy Huddleston Sequoia wrote:
quoted
Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better
 handle distro changes to DEF_VER

Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae
Signed-off-by: Jeremy Huddleston Sequoia <redacted>
I see there was a discussion elsewhere on the list about exactly what
you are putting into DEF_VAR that causes the problem. Perhaps the commit
message here would be a good place to mention that, why the current
regex breaks it, and why your new version fixes not only it, but other
possible values of DEF_VAR.
Ah, should have known that you'd already be helping with this.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help