Re: Regression: git no longer works with musl libc's regex impl

On Tue, Oct 4, 2016 at 6:16 PM, Johannes Schindelin
[off-list ref] wrote:

Hi Rich,

On Tue, 4 Oct 2016, Rich Felker wrote:

quoted

On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote:

quoted

Hi Rich,

On Tue, 4 Oct 2016, Rich Felker wrote:

quoted

On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote:

quoted

On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote:

quoted

1. is nonzero mod page size, it just works; the remainder of the last
   page reads as zero bytes when mmapped.

Is that a portable assumption?

Yes.

No, it is not. You quote POSIX, but the matter of the fact is that we use
a subset of POSIX in order to be able to keep things running on Windows.

And quite honestly, there are lots of reasons to keep things running on
Windows, and even to favor Windows support over musl support. Over four
million reasons: the Git for Windows users.

I would hope that in the future, git-for-windows users will be using
musl, via midipix, rather than the painfully slow and awful version
they're stuck with now...

Git for Windows actually uses the MSVC runtime, which is blazing fast.

You are probably confusing Git for Windows with Cygwin Git.

To be fair, Cygwin Git isn't *that* slow, though I look forward to the
day when MSYS2 can use the native-Windows/GfW version instead
(including your rebase-in-C changes)

Ciao,
Johannes