Thread (1 message) 1 message, 1 author, 2016-09-26

Re: [PATCH v3 1/2] t5100-mailinfo: replace common path prefix with variable

From: Junio C Hamano <hidden>
Date: 2016-09-26 19:06:39

Kevin Daudt [off-list ref] writes:
Many tests need to store data in a file, and repeat the same pattern to
refer to that path:

    "$TEST_DIRECTORY"/t5100/

Create a variable that contains this path, and use that instead.

Signed-off-by: Kevin Daudt <redacted>
Signed-off-by: Junio C Hamano <redacted>
---
 Changes since v2:
 - changed $DATA to $data to indicate it's a script-local variable
If you are rerolling anyway, I would have liked to see the "why is
only the variable part quoted?"  issue addressed which was raised
during the previous round of the review.  I may have said it is OK
to leave it as a low-hanging fruit for others but that only meant
that it alone is not a strong enough reason to reroll this patch.

Other than that, looks good to me, though ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help