Thread (1 message) 1 message, 1 author, 2016-09-24

Re: [PATCH v3 2/2] gitweb: use highlight's shebang detection

From: Junio C Hamano <hidden>
Date: 2016-09-24 17:52:48

Jakub Narębski [off-list ref] writes:
quoted
Also, "curling" is not the word I would like to see. I would say:

  Simple benchmark comparing performance of 'blob' view of files without
  syntax highlighting in gitweb before and after this change indicates
  ±1% difference in request time for all file types.  Benchmark was
  performed on local instance on Debian, using Apache/2.4.23 web server
  and CGI/PSGI/FCGI/mod_perl.

      ^^^^^^^^^^^^^^^^^^^^^^--- select one
or state that all of them produced similar results ;-)
quoted
Or something like that; I'm not sure how detailed this should be.
But it is nice to have such benchmark in the commit message.
Sidenote: this way of benchmarking of gitweb falls between two ways of
doing a benchmark.
All good comments.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help