Re: [PATCH v3 1/2] gitweb: remove unused function parameter
From: Jakub Narębski <hidden>
Date: 2016-09-23 19:45:24
W dniu 23.09.2016 o 11:08, Ian Kelling napisał:
Subject: [PATCH v3 1/2] gitweb: remove unused function parameter
I think it would be better to be more descriptive, and say: Subject: [PATCH v3 1/2] gitweb: remove unused parameter from guess_file_syntax() But that might be too long...
Signed-off-by: Ian Kelling <redacted>
With, or without this change, it's nice. Acked-by: Jakub Narębski <redacted>
quoted hunk ↗ jump to hunk
--- gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 33d701d..6cb4280 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -3913,7 +3913,7 @@ sub blob_contenttype { # guess file syntax for syntax highlighting; return undef if no highlighting # the name of syntax can (in the future) depend on syntax highlighter used sub guess_file_syntax { - my ($highlight, $mimetype, $file_name) = @_; + my ($highlight, $file_name) = @_; return undef unless ($highlight && defined $file_name); my $basename = basename($file_name, '.in'); return $highlight_basename{$basename}@@ -7062,7 +7062,7 @@ sub git_blob { $have_blame &&= ($mimetype =~ m!^text/!); my $highlight = gitweb_check_feature('highlight'); - my $syntax = guess_file_syntax($highlight, $mimetype, $file_name); + my $syntax = guess_file_syntax($highlight, $file_name); $fd = run_highlighter($fd, $highlight, $syntax) if $syntax;