Thread (1 message) 1 message, 1 author, 2016-09-21

Re: [PATCH 3/3] gitweb: Link to "git describe"'d commits in log messages

From: Junio C Hamano <hidden>
Date: 2016-09-21 18:01:24

Jakub Narębski [off-list ref] writes:
quoted
When I saw 2/3 I wondered about one thing and 3/3 shares the same,
which is that we only use regex match and do not validate for a
false match.  Would it be too expensive...
It's a matter of balance between false positives (and unresolving
links) and performance...
Yes, and that is why I asked a simple yes-or-no question.  Would it
be too expensive?  Your answer seems to be yes.

Have we measured?  Is that really a bottleneck?  Would it help to
update parse_commits to call a new command "gitweb--helper" that
produces the result of what git_print_log would have done to its
$log argument, for example?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help