Thread (3 messages) flat view 3 messages, 3 authors, 2016-09-15

Re: [PATCH] use strbuf_addstr() for adding constant strings to a strbuf, part 2

From: Junio C Hamano <hidden>
Date: 2016-09-15 19:25:51

Jeff King [off-list ref] writes:
On Thu, Sep 15, 2016 at 08:31:00PM +0200, René Scharfe wrote:
quoted
Replace uses of strbuf_addf() for adding strings with more lightweight
strbuf_addstr() calls.  This makes the intent clearer and avoids
potential issues with printf format specifiers.

02962d36845b89145cd69f8bc65e015d78ae3434 already converted six cases,
this patch covers eleven more.
Great, these all look obviously correct.
Yes.
quoted
Silly question: Is there a natural language that uses percent signs
as letters or e.g. instead of commas? :)
I don't know, but if they do, they'd better get used to escaping them.
:)
I do not know either, but I am curious where that question comes
from.  I stared at this patch for a few minutes but couldn't guess.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help