Re: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area
From: Junio C Hamano <hidden>
Date: 2016-09-12 19:12:49
Kirill Smelkov [off-list ref] writes:
quoted hunk
Otherwise for people who use autotools-based configure in main worktree, the performance testing results will be inconsistent as work and build trees could be using e.g. different optimization levels. See e.g. http://public-inbox.org/git/20160818175222.bmm3ivjheokf2qzl@sigill.intra.peff.net/ for example. NOTE config.status has to be copied because otherwise without it the build would want to run reconfigure this way loosing just copied config.mak.autogen. Signed-off-by: Kirill Smelkov <redacted> --- ( Resending as separate patch-mail, just in case ) t/perf/run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/t/perf/run b/t/perf/run index cfd7012..aa383c2 100755 --- a/t/perf/run +++ b/t/perf/run@@ -30,7 +30,7 @@ unpack_git_rev () { } build_git_rev () { rev=$1 - cp ../../config.mak build/$rev/config.mak + cp -t build/$rev ../../{config.mak,config.mak.autogen,config.status}
That unfortunately is a GNUism -t with a bash-ism {a,b,c}; just keep
it simple and stupid to make sure it is portable.
This is not even a part that we measure the runtime for anyway.
(cd build/$rev && make $GIT_PERF_MAKE_OPTS) || die "failed to build revision '$mydir'" }