Thread (1 message) 1 message, 1 author, 2016-09-08

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

From: Junio C Hamano <hidden>
Date: 2016-09-08 21:30:57

Jeff King [off-list ref] writes:
quoted
commit f96e5673 ("grep: use REG_STARTEND for all matching if available",
22-05-2010) introduced this test and expects ".. NUL characters themselves
are not matched in any way". With the native library on cygwin they are
matched, with the compat/regex they are not. Indeed, if you use the system
'grep' command (rather than 'git grep'), then it will also not match ... :-D

Slightly off topic, but ...
Hmm. So it sounds like the "regmatch" in grep.c could go away in favor
of Johannes's regexec_buf(), and cygwin ought to be using NO_REGEX.
Sounds like a plan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help