Thread (10 messages) flat view 10 messages, 3 authors, 2016-09-16

Re: [PATCH] sequencer: support folding in rfc2822 footer

From: Jonathan Tan <hidden>
Date: 2016-09-06 23:30:35

On 09/06/2016 03:08 PM, Jonathan Tan wrote:
On 09/02/2016 07:23 PM, Junio C Hamano wrote:
quoted
A slightly related tangent.  An unconditionally good change you
could make is to allow folding of in-body headers.  I.e. you can
have e.g.

    -- >8 --
    Subject: [PATCH] sequencer: support in-body headers that are
         folded according to RFC2822 rules

    The first paragraph after the above long title begins
    here...

in the body of the msssage, and I _think_ we do not fold it properly
when applying such a patch.  We should, as that is something that
appears in format-patch output (i.e. something Git itself produces,
unlike the folded "footer").
OK, I'll take a look at this.
It turns out that Git seems to already do this, at least for Subject. 
Transcript below:

$ echo one > file.txt
$ git add file.txt
$ git commit -m x
[master (root-commit) 2389483] x
  1 file changed, 1 insertion(+)
  create mode 100644 file.txt
$ echo two > file.txt
$ git commit -am 'this is a very long subject to test line wrapping this 
is a very long subject to test line wrapping'
[master ca86792] this is a very long subject to test line wrapping this 
is a very long subject to test line wrapping
  1 file changed, 1 insertion(+), 1 deletion(-)
$ git format-patch HEAD^
0001-this-is-a-very-long-subject-to-test-line-wrapping-th.patch
$ cat 0001-this-is-a-very-long-subject-to-test-line-wrapping-th.patch
<snip>
Subject: [PATCH] this is a very long subject to test line wrapping this is a
  very long subject to test line wrapping
<snip>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help