Thread (146 messages) 146 messages, 6 authors, 2017-01-02

Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'

From: Johannes Schindelin <hidden>
Date: 2016-09-02 07:32:20

Hi Dennis,

On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote:
/*
 * Note that ordering matters in this enum. Not only must it match the
 * mapping below, it is also divided into several sections that matter.
 * When adding new commands, make sure you add it in the right section.
 */
enum todo_command {
	/* All commands that handle commits */
	TODO_PICK,
	...
	/* All commands that do something else than pick */
	TODO_EXEC,
	...
	/* All commands that do nothing but are counted for reporting progress */
	TODO_NOOP,
	...
	/* Comments, which are not counted
	TODO_COMMENT
}
I like it! Changed accordingly.

Thanks!
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help