Thread (8 messages) flat view 8 messages, 3 authors, 2016-08-30

Re: [PATCH v4 0/3] diff-highlight: add support for --graph option

From: Jeff King <hidden>
Date: 2016-08-30 08:12:05

Possibly related (same subject, not in this thread)

On Mon, Aug 29, 2016 at 10:33:44AM -0700, Brian Henderson wrote:
How does this look?

Drawing the graph helped me a lot in figuring out what I was actually testing. thanks!

Brian Henderson (3):
  diff-highlight: add some tests.
  diff-highlight: add failing test for handling --graph output.
  diff-highlight: add support for --graph output.
These all look good to me. As Junio mentioned, you need to add a
signoff (see the section "Sign your work" in Documentation/SubmittingPatches).

Also, a minor nit, but we don't usually put a "." at the end of our
commit message subjects (not worth a re-roll on its own, but if you are
sending them again anyway...).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help