Thread (2 messages) 2 messages, 2 authors, 2016-08-30

Re: [PATCH v2 12/14] sequencer: lib'ify save_head()

flat view

From: Junio C Hamano <hidden>
Date: 2016-08-29 20:55:03

Johannes Schindelin [off-list ref] writes:
quoted hunk
 	strbuf_addf(&buf, "%s\n", head);
 	if (write_in_full(fd, buf.buf, buf.len) < 0)
-		die_errno(_("Could not write to %s"), git_path_head_file());
+		return error_errno(_("Could not write to %s"),
+				   git_path_head_file());
Same comment around a left-over lockfile applies to this.  An extra
rollback being minimally intrusive also applies here, I think.
quoted hunk
 	if (commit_lock_file(&head_lock) < 0)
-		die(_("Error wrapping up %s."), git_path_head_file());
+		return error(_("Error wrapping up %s."), git_path_head_file());
+	return 0;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help