On Fri, 2016-08-26 at 12:17 -0700, Stefan Beller wrote:
On Thu, Aug 25, 2016 at 4:32 PM, Jacob Keller <jacob.e.keller@intel.c
om> wrote:
quoted
@@ -487,12 +490,14 @@ static void do_submodule_path(struct strbuf
*buf, const char *path,
strbuf_addstr(buf, git_dir);
}
if (!is_git_directory(buf->buf)) {
+ gitmodules_config();
We determined via chat that calling gitmodules_config
is not harmful w.r.t. correctness, but might require some
improvements in the future for performance.
(i.e. we may want to add in a later series a
if (already called gitmodules_config)
set flag "already called gitmodules_config";
return;
into gitmodules_config)
quoted
char *git_pathdup_submodule(const char *path, const char *fmt,
...)
{
+ int err;
va_list args;
struct strbuf buf = STRBUF_INIT;
va_start(args, fmt);
- do_submodule_path(&buf, path, fmt, args);
+ err = do_submodule_path(&buf, path, fmt, args);
va_end(args);
+ if (err)
Here we need a strbuf_release(&buf) to avoid a memory leak?
No, cause we "strbuf_detach" after this to return the buffer? Or is
that not safe?
Thanks,
Jake
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html