Thread (4 messages) flat view 4 messages, 4 authors, 2016-08-27

Re: [PATCH 1/2] gitk: align the commit summary format to the documentation

From: Stefan Beller <hidden>
Date: 2016-08-26 19:16:29

On Fri, Aug 26, 2016 at 11:24 AM, Junio C Hamano [off-list ref] wrote:
Beat Bolli [off-list ref] writes:
quoted
In 175d38c (SubmittingPatches: document how to reference previous commits,
2016-07-28) the format for referring to older commits was specified.

Make the text generated by the "Copy commit summary" command match this
format.
Hmph.  I didn't know gitk already had its own command to produce a
short string.  I actually think what it produces
It was added in d835dbb91fe (gitk: Add a "Copy commit summary" command,
2015-07-18), it doesn't seem to be in your tree yet, so maybe wait
with this patch
until you pulled gitk?
quoted
In 175d38c ("SubmittingPatches: document how to reference previous commits",
2016-07-28) the format for referring to older commits was specified.
is easier to read when pasted into a sentence than what the recent
update 175d38ca ("SubmittingPatches: document how to reference
previous commits", 2016-07-28) suggests to do, i.e.
quoted
In 175d38c (SubmittingPatches: document how to reference previous commits,
2016-07-28) the format for referring to older commits was specified.
Heiko, Stefan, I think you two were involved in adding that new
paragraph.   What do you think?
So the subtle difference is adding '"' around the commit message subject?

I agree we should fix that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help