Re: [PATCH v6 10/13] convert: generate large test files only once

On 25 Aug 2016, at 21:17, Stefan Beller [off-list ref] wrote:

quoted

On Thu, Aug 25, 2016 at 4:07 AM,  [off-list ref] wrote:
From: Lars Schneider <redacted>

Generate more interesting large test files

How are the large test files more interesting?
(interesting in the notion of covering more potential bugs?
easier to debug? better to maintain, or just a pleasant read?)

The old large test file was 1MB of zeros and 1 byte with a one, repeated 2048 times.

Since the filter uses 64k packets we would test a large number of equally looking packets.

That's why I thought the pseudo random content is more interesting.

quoted

with pseudo random characters
in between and reuse these test files in multiple tests. Run tests
formerly marked as EXPENSIVE every time but with a smaller data set.

Sounds good to me.

Thank you.
Lars